Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cypress test for issue 1944 #2055

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Cypress test for issue 1944 #2055

merged 1 commit into from
Aug 21, 2020

Conversation

dvkruchinin
Copy link
Contributor

Cypress test for issue 1944

Motivation and context

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@dvkruchinin dvkruchinin requested a review from azhavoro as a code owner August 19, 2020 11:01
@coveralls
Copy link

coveralls commented Aug 19, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 6999

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 69.721%
Totals Coverage Status
Change from base Build 6998: 0.0%
Covered Lines: 11725
Relevant Lines: 16363
💛 - Coveralls

@dvkruchinin dvkruchinin force-pushed the dkru/cypress_test_issue_1944 branch from 1c33b3f to 35b30d1 Compare August 19, 2020 12:03
@dvkruchinin
Copy link
Contributor Author

dvkruchinin commented Aug 19, 2020 •
edited
Loading

Rebase due changes in the "createAnnotationTask" cypress command.

@bsekachev
Copy link
Member

@dvkruchinin Was you able to reproduce the issue without any problem?

@dvkruchinin
Copy link
Contributor Author

@dvkruchinin Was you able to reproduce the issue without any problem?

There were no problems. When checking the test on the commit before fix, I got an infinite preloader when switching jobs. There was no need to switch between jobs more than once.

@bsekachev bsekachev merged commit 822a3b5 into cvat-ai:develop Aug 21, 2020
@dvkruchinin dvkruchinin deleted the dkru/cypress_test_issue_1944 branch August 24, 2020 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsekachev bsekachev bsekachev approved these changes

@azhavoro azhavoro Awaiting requested review from azhavoro azhavoro is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dvkruchinin @coveralls @bsekachev